Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Playwright to v1.48.0 #398

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Update Playwright to v1.48.0 #398

merged 2 commits into from
Oct 14, 2024

Conversation

leventebalogh
Copy link
Collaborator

@leventebalogh leventebalogh commented Oct 14, 2024 •
edited
Loading

@jackw spotted that our integration tests started failing due to the github runners using Ubuntu 24.04 instead of 22.04. Turns out we need to bump Playwright to support Ubuntu 24.04.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@leventebalogh leventebalogh marked this pull request as ready for review October 14, 2024 11:49
@leventebalogh leventebalogh requested review from a team as code owners October 14, 2024 11:49
@leventebalogh leventebalogh requested review from academo, wbrowne, andresmgot, xnyo and jackw and removed request for a team October 14, 2024 11:49
jackw
jackw approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@leventebalogh leventebalogh merged commit b740ee2 into main Oct 14, 2024
20 checks passed
@leventebalogh leventebalogh deleted the leventebalogh/integration-tests-playwright branch October 14, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

@xnyo xnyo Awaiting requested review from xnyo xnyo is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees
No one assigned
Labels
None yet
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leventebalogh @CLAassistant @jackw