rename namespace selector #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedroche
approved these changes
Feb 5, 2019
9 tasks
kd7lxl
referenced
this pull request
in kd7lxl/grafana-operator
Mar 11, 2021
hubeadmin
pushed a commit
that referenced
this pull request
Sep 7, 2021
* General linter from github * Follow the docs * Fix CI image * comment out yaml githubactions * Add api.md to markdown ignore * Test again * Update markdown ignore again * Fix markdown lint (#5) * Fix markdown lint * fix lint github action * don't think i need it * and i did ^ ^ * file with error in it * Fix dashboards * trigger api.md bad file * linting markdown deploy examples * Fix row and remove changes to api.md * remove more api-md * put super-lint in the big file * enable github action lint check * Disable Github actions lint * Update ./README.md and ignore rules * Fix some long rows in md * does the ignore work? * yes it does * Update SECURITY.MD * extra space in env_vars.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
monitoringNamespaceSelectortodashboardNamespaceSelectorto make it more clear what is selected here.Verification steps:
deploy/examples/Grafany.yamloc label namespace <ns> monitoring-key=middleware"Checking namespace <ns> for dashboards