Chore(Internal): Add new shared reconciliation functions and migrate GrafanaFolder
#1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the folder E2E test works, this is unlikely to have introduced any regressions. |
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess and
pb82
as code owners
theSuess
requested changes
Nov 25, 2024
Baarsgaard
force-pushed
the
update_folder_reconciliation
branch
2 times, most recently
from
3692ecf to
b112b69
Compare
|
I've applied your suggestions as well as added some test cases for the new list functions for Grafana instances. |
weisdd
requested changes
Nov 26, 2024
Baarsgaard
force-pushed
the
update_folder_reconciliation
branch
from
b112b69 to
c66b5e1
Compare
Baarsgaard
changed the title
GrafanaFolder
Baarsgaard
force-pushed
the
update_folder_reconciliation
branch
2 times, most recently
from
ca83723 to
598c1c6
Compare
Baarsgaard
force-pushed
the
update_folder_reconciliation
branch
from
598c1c6 to
1f715ff
Compare
Baarsgaard
force-pushed
the
update_folder_reconciliation
branch
from
1f715ff to
52fed3e
Compare
theSuess
approved these changes
Dec 9, 2024
weisdd
approved these changes
Dec 9, 2024
|
Can we expect this PR be merged this week? so I can continue to work on #1775. Thanks all! |
|
@chenlujjj at the moment, we're waiting for @pb82 to take a look at the changes. We do not expect to see any significant changes, it's more about double-check we're not breaking anything here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve how reconciliation functions are written going forward, starting with the folder controller.
The goal is to reduce duplicated code by moving more logic into matching Grafana instances.
This is achieved by namespacing the client to limit the scope of the search when resources do not specify
allowCrossNamespaceImport: trueAdditional functions have been added for simplifying building conditions when no matching instances are found.
Lastly, it aligns the existing folder reconcile error logging with other resources