Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release helm charts to grafana/helm-charts #1734

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

theSuess
Copy link
Member

Implements #1732

Uses the same approach as the k6-operator to publish releases to the grafana/helm-charts repo

@theSuess
Copy link
Member Author

We might want to split this into a separate task to allow for faster iteration without triggering the complete release flow

@weisdd
Copy link
Collaborator

weisdd commented Oct 29, 2024

I'm not entirely sure if I correctly understood the workflow, but seems like, amongst other artifacts, it'll push an OCI artifact to the same repository as we do now, which means we'll push it twice (through helm-oci and helm-charts-repo). What's also important is that the new workflow relies on helm v3.5.2 (was released in Feb 2021), whereas support for OCI graduated to GA only in v3.8.0 (e.g. prior to v3.7.0, helm used a different layer media type), so the artifacts would not be the same. I'm not sure if it'll break anything, but it's certainly not a good practice to use such an old helm version :)

UPD: I see that helm version has got updated in the workflow in the helm-charts repository a few hours ago, so helm version is not a concern anymore, but the fact that we would attempt to push to the same repository - is (again, assuming I've correctly understood the workflow).

@CarlosLanderas
Copy link

CarlosLanderas commented Oct 29, 2024

Thanks for this @theSuess . I was suffering the problem you mention in the open issue and need to install grafana operator from non OCI source.

@theSuess theSuess force-pushed the feat/helm-release-to-repo branch from e7bb88a to bc9ee8a Compare October 30, 2024 11:24
@theSuess
Copy link
Member Author

Good call @weisdd! I switched from just importing the chart to just pushing the release from our release flow as I also realized that the change detection doesn't work for our use case

@theSuess theSuess force-pushed the feat/helm-release-to-repo branch 3 times, most recently from 03ab20f to e86dc37 Compare November 4, 2024 08:01
@theSuess theSuess force-pushed the feat/helm-release-to-repo branch from e86dc37 to 7ab5730 Compare November 4, 2024 08:58
@theSuess theSuess added this pull request to the merge queue Nov 4, 2024
Merged via the queue into master with commit bc65dc3 Nov 4, 2024
14 checks passed
@theSuess theSuess deleted the feat/helm-release-to-repo branch November 4, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants