Adds .svc to internal grafana adminUrl
#1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amimof
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess and
pb82
as code owners
|
|
theSuess
approved these changes
Oct 14, 2024
|
Thanks for the PR! For seamless e2e openshift we'll still need to tackle #1683, but this is definitely a step in the right direction |
theSuess
force-pushed
the
add-svc-to-internal-adminurl
branch
from
106d22f to
53b9c17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #1712 where the issue is that the url used to connect to a Grafana instance through a Service is incorrectly generated by the reconciler. This causes errors like.