refactor: move tls block to spec.client

[theSuess]

This change allows for tls configuration on operator-managed grafana instances.
Fixes #1675

[theSuess]

@diranged can you try this against your setup?

You'll have to use the same insecureSkipVerify configuration as in the e2e test unless your certificate also includes the service host name

[diranged]

@theSuess I can test this if you want to push an image up...

[theSuess]

@diranged sorry for the late reply, was out for a conference the last few days.

You can use ghcr.io/grafana/grafana-operator:pr-1690 to test this change. Be sure to also update the CRDs to use the version from this branch

[diranged]

@theSuess,
Sorry for my delay too! So its easy for me to test a custom image ... however, it's trickier to test the CRD because the CRDs are actively managed and pushed by ArgoCD and kept in sync that way. If your code passes tests, can we just get it released and try it out?

[weisdd]

@theSuess the code seems to be fine as confirmed by e2e. My only suggestion would be to, probably, update the docs with TLS block proposal to say that it's now advised to use the top-level block.

[diranged]

Closing the loop here - this works!