-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add folderUID and folderRef in GrafanaDashboard CRD #1601
feat: Add folderUID and folderRef in GrafanaDashboard CRD #1601
Conversation
@theSuess - I know you are interested about this implementation. If it can help you to propose something even better, feel free to propose an evolution in a dedicated MR and close this one. |
c2cd3f3
to
203ff7c
Compare
Waiting for #1604 to be merged first as it introduces shared logic we can reuse here |
203ff7c
to
f635d15
Compare
…encer interface and remove not mutualized code from controler
f635d15
to
c2d19da
Compare
@theSuess I have updated the GrafanaDashboard CR to match with the interface. To do this, I have added a Condition block into the GrafanaDashboard.Status and add the state update into the Reconciliation loop. I removed the duplicated code with the interface developed in the GrafanaFolder MR (#1604). Can you have a look on it? I don't understand the full meaning of the Condition object, I would be happy if someone can give me some feedback into this implementation. I think I'm ready for a review this time. |
…/folderRef with kubebuilder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this! I found a few minor nitpicks but looks great overall!
…board description
Aim of the merge request
This MR aims to implement the content of the document discussed in maintainer meeting (currently under #1592).
The features are the following:
If
folder
is set and none of the other fields is set (backwards compat. case): Create the folderIf
folderUID
orfolderRef
is set, don't create the folderIf
folderUID
orfolderRef
AND folder is set, the new fields take priority -> don't create the folderBreaking change
There is no breaking change. We implement on the top of existing GrafanaDashboard CR behavior.