Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(controller-shared): simplify labelsSatisfyMatchExpressions #1542

Merged
merged 3 commits into from
May 21, 2024
Merged

chore(controller-shared): simplify labelsSatisfyMatchExpressions #1542

merged 3 commits into from
May 21, 2024

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented May 19, 2024

That's a tiny follow-up PR for #1497:

  • The case for absent matchExpressions in instanceSelector is already covered by return true, so no need for len(matchExpressions) check;
  • Got rid of double-import for meta/v1.

@weisdd weisdd force-pushed the chore/simplify-labelsSatisfyMatchExpressions branch from 614261f to d1f6870 Compare May 21, 2024 07:02
@weisdd weisdd enabled auto-merge May 21, 2024 07:03
@weisdd weisdd merged commit b773228 into master May 21, 2024
10 checks passed
@weisdd weisdd deleted the chore/simplify-labelsSatisfyMatchExpressions branch May 21, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NissesSenap NissesSenap NissesSenap approved these changes

@theSuess theSuess theSuess approved these changes

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weisdd @theSuess @NissesSenap