chore: add test files for secure json data in kind #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuda
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
smuda
force-pushed
the
chore/add-kind-test-files-for-secureJsonData
branch
from
394fcad to
34a5dd1
Compare
smuda
changed the title
|
Hey @smuda ! Thanks for your contributions recently! we really appreciate it! One question on this PR though, was the intention to have the secureJsonData test to run as part of the chainsaw e2e tests? |
|
No it wasn't. I'm in the process of creating such a test as well but this was just to help in the manual tests of #1488 :-) |
Thanks! Just wanted to make sure you didn't miss it by accident, but since this is intentional, that's fine with me 😅 |
hubeadmin
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test files in kind for verifying the existence of Authorization header with GrafanaDatasources with secureJsonData.