-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace to templates #1322
Conversation
@rasebo I'm not familiar with Helm, but wouldn't you set the namespace with the CLI? |
f29d289
to
346bef5
Compare
It can be, but this chart can also be used as a subchart, in which care you can end-up with a more complicated setup, where you might have some resources deployed to different namespaces, as part of the same parent chart. In that scenario, it's a good idea to have all manifests specify the namespace where they can be deployed onto because a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think the RBAC template is a bit off (seems like it's always been the case) as cluster-scope resources should not have "metadata.namespace" field. The rest is good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding namespaces to templates in order to avoid having objects deployed to the
default
namespace in certain deployment scenarios.