Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich grafana-controller-manager pod labels #619

Open
samuelvl opened this issue Nov 23, 2021 · 1 comment
Open

Enrich grafana-controller-manager pod labels #619

samuelvl opened this issue Nov 23, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@samuelvl
Copy link

Is your feature request related to a problem? Please describe.
I want to get operator pods filtering by labels, however the only label that is available is control-plane: controller-manager which could lead to confusion if another operator uses this same label.

# I'd like to get only grafana-operator pod
$ oc get pods -l control-plane=controller-manager 
NAME                                                          READY   STATUS    RESTARTS      AGE
airflow-on-k8s-operator-controller-manager-7468c9b786-btc7g   1/1     Running   0             17h
grafana-operator-controller-manager-6496c7d568-dpmlj          2/2     Running   1 (18h ago)   18h

$ oc get pod grafana-operator-controller-manager-6496c7d568-dpmlj --show-labels
NAME                                                   READY   STATUS    RESTARTS      AGE   LABELS
grafana-operator-controller-manager-6496c7d568-dpmlj   2/2     Running   1 (18h ago)   18h   control-plane=controller-manager,pod-template-hash=6496c7d568

Describe the solution you'd like
Add more labels to the operator deployment following k8s best practices https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels. For example:

labels:
    app.kubernetes.io/name: grafana-operator
    app.kubernetes.io/instance: controller-manager
    app.kubernetes.io/component: manager
    app.kubernetes.io/managed-by: olm
@samuelvl samuelvl added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 23, 2021
@pb82 pb82 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 23, 2021
@pb82
Copy link
Collaborator

pb82 commented Nov 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants