Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] OLM annotation make bundle/redhat manual #1313

Closed
NissesSenap opened this issue Nov 21, 2023 · 2 comments · Fixed by #1344
Closed

[Bug] OLM annotation make bundle/redhat manual #1313

NissesSenap opened this issue Nov 21, 2023 · 2 comments · Fixed by #1344
Labels
bug Something isn't working help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@NissesSenap
Copy link
Collaborator

Describe the bug

As a part of the release cycle we are running make bundle/redhat, this generates bundle/metadata/annotations.yaml.
This file currently contains

annotations:
  # Core bundle annotations.
  operators.operatorframework.io.bundle.mediatype.v1: registry+v1
  operators.operatorframework.io.bundle.manifests.v1: manifests/
  operators.operatorframework.io.bundle.metadata.v1: metadata/
  operators.operatorframework.io.bundle.package.v1: grafana-operator
  operators.operatorframework.io.bundle.channels.v1: alpha
  operators.operatorframework.io.metrics.builder: operator-sdk-v1.32.0
  operators.operatorframework.io.metrics.mediatype.v1: metrics+v1
  operators.operatorframework.io.metrics.project_layout: go.kubebuilder.io/v3

  # Annotations for testing.
  operators.operatorframework.io.test.mediatype.v1: scorecard+v1
  operators.operatorframework.io.test.config.v1: tests/scorecard/

We should either remove scorecard or start to enable it as a part of the https://github.com/k8s-operatorhub/community-operators PRs.

The release channel is currently alpha, so I manually had to change it to v5.

This should be fixed during some generation or in some other manifests. This way we don't have to do it manually.

Version
N/A

To Reproduce

make bundle/redhat

Expected behavior

The scorecard annotation shoulden't be added.

Suspect component/Location where the bug might be occurring
Please provide this if you know where this bug might occur otherwise leave as unknown

Somewhere in config/

@NissesSenap NissesSenap added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 21, 2023
@NissesSenap NissesSenap added help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 21, 2023
@pb82
Copy link
Collaborator

pb82 commented Nov 24, 2023

Should have mentioned that, I currently remove those two lines manually when creating a release.

@NissesSenap
Copy link
Collaborator Author

I missed that this issue already existed: #1245
So similar but not exactly the same.
But please fix that at the same time :)

theSuess added a commit that referenced this issue Dec 11, 2023
This picks up some pieces left by #1339 and updates the support information in
the cluster service version.

Should also fix #1313 and #1245
theSuess added a commit that referenced this issue Dec 11, 2023
This picks up some pieces left by #1339 and updates the support information in
the cluster service version.

Should also fix #1313 and #1245
theSuess added a commit that referenced this issue Dec 11, 2023
This picks up some pieces left by #1339 and updates the support information in
the cluster service version.

Should also fix #1313 and #1245
theSuess added a commit that referenced this issue Dec 11, 2023
This picks up some pieces left by #1339 and updates the support information in
the cluster service version.

Should also fix #1313 and #1245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants