This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Retrieve data source by name #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
requested review from
inkel,
undef1nd,
julienduchesne and
malcolmholmes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client does not have support (yet) to get a single data source by name.
So, this adds such support, in a very similar way the
DataSourceByUIDworks now for uids.PS: I was about to re-use the new method for
DataSourceIDByName, but apparently that method is using a different endpoint (/api/datasources/id/, not/api/datasources/name/).