Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Add datasource caching API #158

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Add datasource caching API #158

merged 1 commit into from
Aug 2, 2023

Conversation

cindy
Copy link
Contributor

@cindy cindy commented Aug 1, 2023

Adding support for the datasource caching API.

This is needed to enable support for the terraform provider

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023

CLA assistant check
All committers have signed the CLA.

@cindy cindy force-pushed the cpallares/datasource-cache branch from 61bce36 to ae8a33d Compare August 1, 2023 17:00
@cindy cindy self-assigned this Aug 2, 2023
@cindy cindy marked this pull request as ready for review August 2, 2023 18:11
@cindy cindy requested review from inkel and julienduchesne August 2, 2023 18:12
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small suggestions, other than that, LGTM!

datasource_cache_test.go Outdated Show resolved Hide resolved
datasource_cache_test.go Outdated Show resolved Hide resolved
@cindy cindy requested a review from inkel August 2, 2023 19:15
@cindy cindy force-pushed the cpallares/datasource-cache branch from 181e96e to 755d9f0 Compare August 2, 2023 19:17
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cindy cindy merged commit 1a12415 into master Aug 2, 2023
@cindy cindy deleted the cpallares/datasource-cache branch August 2, 2023 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants