This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Fixed folder pagination #134
Merged
+41
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This looks familiar. :D <3 |
|
@davidnewhall This is needed for an internal project at Booking.com. Any chance you could approve it, please? :) |
|
@Jramirezg I absolutely can, but I don't have any permissions on this repo. |
|
Any idea of who I can approach that can merge it? |
|
One of the Grafana devs came through and merged mine without any 'asking'. I suspect they look from time to time. Your contribution looks a lot like mine, so I imagine they won't have a problem accepting it. If you have enterprise support, maybe ask your TAM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR offers support to the terraform provider for Grafana for folder search. Currently a folder search does not include results beyond 1000 items since the pagination was not in place.