Merge pull request #163 from grafana/err-not-found

Typed error for Not Found (404) responses
grafana · Oct 4, 2023 · 393a4f4 · 393a4f4
2 parents b3a3c20 + f575f36
commit 393a4f4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/client.go b/client.go
@@ -138,7 +138,12 @@ func (c *Client) request(method, requestPath string, query url.Values, body []by
 	}
 
 	// check status code.
-	if resp.StatusCode >= 400 {
+	switch {
+	case resp.StatusCode == http.StatusNotFound:
+		return ErrNotFound{
+			BodyContents: bodyContents,
+		}
+	case resp.StatusCode >= 400:
 		return fmt.Errorf("status: %d, body: %v", resp.StatusCode, string(bodyContents))
 	}
 

diff --git a/errors.go b/errors.go
@@ -0,0 +1,11 @@
+package gapi
+
+import "fmt"
+
+type ErrNotFound struct {
+	BodyContents []byte
+}
+
+func (e ErrNotFound) Error() string {
+	return fmt.Sprintf("status: 404, body: %s", e.BodyContents)
+}