Add optional initContainers and volumes #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Young <[email protected]>
Signed-off-by: David Young <[email protected]>
Signed-off-by: David Young <[email protected]>
Signed-off-by: David Young <[email protected]>
|
Following up from #16, this PR adds the option to include additional initContainers, volumes, and volumeMounts (on the primary container). The use-case here for large tests which required external data. We have about 300MB of files which we upload/download as part of a test, and the easiest way to get these into a loadtest is via an initContainer and an emptyDir mount. This would also satisfy the requests for running tests from configMaps, per #7 |
Add support for initContainer
Signed-off-by: David Young <[email protected]>
Signed-off-by: David Young <[email protected]>
Signed-off-by: David Young <[email protected]>
…flagger-k6-webhook into add-optional-initContainer
Signed-off-by: David Young <[email protected]>
|
Ugh. I messed up both PRs. Creating 2 clean ones... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Young [email protected]