-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade otel deps #391
Conversation
6b4751a
to
665a55b
Compare
Hey @SimenB just a quick update: The problem with sending timings in LongBits instead of a string/number is solved. |
412f04f
to
0bb678d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw 😀
👏 Would love to see a publish as well 🙏 |
Hey Simen, we plan to release a new version tomorrow (Wednesday). |
Why
Some users of the Web-Tracing package reported problems due to incompatible OTEL versions.
To give the package more stability we declare the necessary versions as peerDependencies.
I also manually tested it with the Faro demo and could not find any problems.
What
Note (solved):
Some otel packages depend on a broken otel.js version which sends time as an object instead of a timestamp.
Even with forcing the newest package version, which was mentioned that it fixed it, the problem still persists.
See issues:
Status 400 because of malformed time properties:
Example for package which references the broken version:
Update:
The issue is fixed.
We can either wait till the packages use the newest version or downgrade.
Thoughts?
cc @cedricziel
Links
Checklist