Timeseries panels: Map field display names to color #937
+53
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk-grafana
commented
Dec 4, 2024
gtk-grafana
commented
Dec 4, 2024
…-values-ui-updates' into gtk-grafana/issues/862/drilldown-values-ui-updates__sync-colors-by-name-poc
…2/drilldown-values-ui-updates
…o gtk-grafana/issues/862/drilldown-values-ui-updates__sync-colors-by-name-poc
gtk-grafana
changed the title
matyax
approved these changes
Dec 9, 2024
|
Going to wait on merge of parent branch and merge this into main to keep that parent PR from getting any bigger. |
Base automatically changed from
gtk-grafana/issues/862/drilldown-values-ui-updates
to
main
December 10, 2024 14:41
…o gtk-grafana/issues/862/drilldown-values-ui-updates__sync-colors-by-name-poc
…2/drilldown-values-ui-updates__sync-colors-by-name-poc
…2/drilldown-values-ui-updates__sync-colors-by-name-poc
gtk-grafana
deleted the
gtk-grafana/issues/862/drilldown-values-ui-updates__sync-colors-by-name-poc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#936 introduced a new "summary" panel to the value breakdowns, but the colors of the series don't match up, which reduces the summary panel's ability to help use volume and other relationships between the series to decide what to filter.
While #939, should help, as that PR would allow users to interact more directly with the viz, having the same colors used in both the breakdowns and summary series will greatly reduce the effort required to match series in the summary panel to the breakdowns.
Any series throughout the app with the same field name will have the same color:
Except fields aggregated by level, which will show canonical error: red, warning: orange, etc
Summary panels will now match breakdown panels:
