Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is a draft PR that adds a new READONLY
InstanceState
, and support to set thejoinedState
before starting the lifecycler.joinedState
defaults to ACTIVEjoinedState
joinedState
s are ACTIVE and READONLYNotes and/or TODOs:
joinedState
could (should?) be a config option instead, if we don't ever need to change it after creating the lifecyclerjoinedState
after the lifecycler has joined the ring has no effectjoinedState
is set to READONLY but the lifecycler finds the instance in the ACTIVE state in the ring, it won't switch the ring state to matchjoinedState
-- it probably shouldcfg.ObservePeriod
setting, but we should probably add someTransferChunks
state transitions are still necessary, and if we need to add JOINING -> READONLY as a valid oneIsHealthy()
, and used for Read operations.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]