Lifecycler: return the number of instances in lifecycler's zone #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pracucci
reviewed
Feb 12, 2023
pracucci
approved these changes
Feb 15, 2023
duricanikolic
force-pushed
the
yuri/issue-4208
branch
from
25f10e7
to
b392a57
Compare
pstibrany
reviewed
Feb 21, 2023
Comment on lines
+814
to
+816
| if _, ok := zones[ingester.Zone]; !ok { | ||
| zones[ingester.Zone] = 0 | ||
| } |
There was a problem hiding this comment.
Nit: Setting default value 0 to zones[ingester.Zone] is unnecessary. zones[ingester.Zone]++ below will work just fine without this.
There was a problem hiding this comment.
Hi @pstibrany,
This assignment is needed in order to count the total number of zones. If we remove the block setting 0 to zones[ingester.Zone], we will count only the number of zones with healthy ingesters.
There was a problem hiding this comment.
Good point that I missed! That's worth adding a comment in my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR enriches
Lifecyclerwith theInstancesInZoneCount()method, that returns the number of instances in ring belonging to the lifecycler's zone, updated during the last heartbeat period.A test (
TestLifecycler_InstancesInZoneCount) showing the expected behaviour ofInstancesInZoneCount()has been added.Which issue(s) this PR fixes:
This PR is a pre-requisite for fixing the issue 4208.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]