Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Tag and Version this project #201

Open
gruyaume opened this issue Sep 26, 2024 · 1 comment
Open

[enhancement] Tag and Version this project #201

gruyaume opened this issue Sep 26, 2024 · 1 comment

Comments

@gruyaume
Copy link

Description

We use the Grafana dashboard linter in many of our CI's to ensure we keep a consistent quality level in our dashboards.

The project is not tagged at the moment, leading us to point to the @latest version of the go package.

Impact

This resulted in all of our CI's that use the grafana dashboard linter to fail this week because of a breaking change in the linter (addition of logql rules). While this change is welcomed, it should have been associated with a new version of the project, and we could have made this change on its own.

Reference

GitHub action workflow

name: Lint Grafana Dashboard

on:
  workflow_call:


jobs:
  lint-grafana:
    runs-on: ubuntu-22.04
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Setup Go
        uses: actions/setup-go@v5
        with:
          go-version: '1.22'
      - name: Install Grafana Dashboard Linter
        run: go install github.com/grafana/dashboard-linter@latest
      - name: Run Grafana Dashboard Lint
        run: dashboard-linter lint src/grafana_dashboards/* --strict -c grafana.lint
@sid-maddy
Copy link

Seems like a duplicate of #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants