Merge pull request #193 from diurnalist/b/loop-capture-var

fix loop var bug in fixable results

lint/rules.go

@@ -26,6 +26,7 @@ func (f DashboardRuleFunc) Lint(d Dashboard, s *ResultSet) {
 	}
 	rr := make([]FixableResult, len(dashboardResults))
 	for i, r := range dashboardResults {
+		r := r // capture loop variable
 		var fix func(*Dashboard)
 		if r.Fix != nil {
 			fix = func(dashboard *Dashboard) {

lint/rules_test.go

@@ -67,3 +67,35 @@ func TestCustomRules(t *testing.T) {
 		})
 	}
 }
+
+func TestFixableRules(t *testing.T) {
+	sampleDashboard, err := os.ReadFile("testdata/dashboard.json")
+	assert.NoError(t, err)
+
+	rule := lint.NewDashboardRuleFunc(
+		"test-fixable-rule", "Test fixable rule",
+		func(d lint.Dashboard) lint.DashboardRuleResults {
+			rr := lint.DashboardRuleResults{}
+			rr.AddFixableError(d, "fixing first issue", func(d *lint.Dashboard) {
+				d.Title += " fixed-once"
+			})
+			rr.AddFixableError(d, "fixing second issue", func(d *lint.Dashboard) {
+				d.Title += " fixed-twice"
+			})
+			return rr
+		},
+	)
+
+	rules := lint.RuleSet{}
+	rules.Add(rule)
+
+	dashboard, err := lint.NewDashboard(sampleDashboard)
+	assert.NoError(t, err)
+
+	results, err := rules.Lint([]lint.Dashboard{dashboard})
+	assert.NoError(t, err)
+
+	results.AutoFix(&dashboard)
+
+	assert.Equal(t, "Sample dashboard fixed-once fixed-twice", dashboard.Title)
+}