This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Support storage HMAC key #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: crossplane-contrib#51 This resource is needed to do S3-style access on GCS buckets As this comment shows: crossplane-contrib#197 (comment), this resource causes an import cycle However, we can resolve that by putting the resource in the `cloudplatform` package. While, this key is specific to storage, it is still just a product of a service account and isn't linked to any storage resources. Signed-off-by: Julien Duchesne <[email protected]>
|
/test-examples="provider-gcp/examples/cloudplatform/storagehmackey.yaml" |
|
/test-examples="examples/cloudplatform/storagehmackey.yaml" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: crossplane-contrib#51 This resource is needed to do S3-style access on GCS buckets
As this comment shows: crossplane-contrib#197 (comment), this resource causes an import cycle However, we can resolve that by putting the resource in the
cloudplatformpackage. While, this key is specific to storage, it is still just a product of a service account and isn't linked to any storage resources.Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested