Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cortex): use first class citizens #153

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Conversation

Duologic
Copy link
Member

for:

  • requiredDuringSchedulingIgnoredDuringExecutionType
  • portsType

These are available from: https://github.com/jsonnet-libs/k8s-alpha

for:
* requiredDuringSchedulingIgnoredDuringExecutionType
* portsType

These are available from: https://github.com/jsonnet-libs/k8s-alpha
@Duologic Duologic requested a review from a team as a code owner July 31, 2020 14:27
@Duologic
Copy link
Member Author

Backwards compatibility similar to grafana/loki#2525

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as it's a backward compatibile no-op, then LGTM

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtlisi jtlisi merged commit ada12a9 into master Sep 9, 2020
@jtlisi jtlisi deleted the duologic/k8s-alpha branch September 9, 2020 15:00
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
…8s-alpha

refactor(cortex): use first class citizens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants