-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support format dropdown and support for rendering traces #329
Conversation
@bossinc my tests pass locally. Can you put the CI failures here please. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Great development, I previously opened a discussion on Grafana but did not think opening an issue here. grafana/grafana#62924 I followed the instructions here to test it locally https://grafana.com/tutorials/build-a-data-source-plugin/ and but from the on the UI I see Plugin unavailable and same in logs and the additional this line: (I use M1 mac)
I did not see any info on DEV_GUIDE.md about it. I might be missing a thing. My plugin/dist folder is as follows:
|
@mustafaakin maybe Grafana team will help you to run the plugin with Docker. In the meantime, you can try to run Grafana from sources following the guide https://github.com/grafana/grafana/blob/main/contribute/developer-guide.md |
This PR adds support for rendering traces in Explore and the traces panel. This is achieved through several changes:
json.RawMessage
. This allows tags to rendered correctly. I think this is an improvement and shouldn't impact previous approach - which returned them as a string.Auto
which means the current behaviour - so no backward compatibility break. If the user specifies the format it overrides the value sent to the server.Note we maintain full backwards compatibility.
Thus also closes #300