Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct behavior of glob-based attribute selection #995

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jul 4, 2024

Changed the recently added behavior to be easier to predict and understand:

  1. For each matching group of attributes, ordered from more general to more concrete:
    1.1. Add the attributes in the inclusion list.
    1.1.1. If the first matching group is empty, add the default attributes list.
    1.2. Remove the attributes in the exclusion list.

This would simplify overriding generic definitions with concrete use cases. (E.g. re-include an attribute that was explicitly excluded in the general definition).

@mariomac mariomac requested review from grcevski and marctc as code owners July 4, 2024 09:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.89%. Comparing base (58de56a) to head (df93c17).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   80.75%   75.89%   -4.87%     
==========================================
  Files         134      134              
  Lines       10721    10720       -1     
==========================================
- Hits         8658     8136     -522     
- Misses       1558     2085     +527     
+ Partials      505      499       -6     
Flag Coverage Δ
integration-test 56.07% <50.00%> (-0.07%) ⬇️
k8s-integration-test ?
oats-test 36.41% <50.00%> (-0.01%) ⬇️
unittests 50.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 8569c39 into grafana:main Jul 4, 2024
6 checks passed
@mariomac mariomac deleted the glob-select branch July 4, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants