Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add logging on pod/svc ip k8s operations (#990)" #993

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 3, 2024

We fixed the issue in #933, these logs are not needed anymore.

This reverts commit 3f9fe7f.

@marctc marctc requested review from grcevski and mariomac as code owners July 3, 2024 18:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (683b50d) to head (299ac5e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   78.72%   80.70%   +1.98%     
==========================================
  Files         134      134              
  Lines       10721    10705      -16     
==========================================
+ Hits         8440     8640     +200     
+ Misses       1753     1558     -195     
+ Partials      528      507      -21     
Flag Coverage Δ
integration-test 56.18% <ø> (?)
k8s-integration-test 59.41% <ø> (-0.06%) ⬇️
oats-test 36.29% <ø> (-0.03%) ⬇️
unittests 50.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marctc marctc merged commit dd47fb0 into main Jul 4, 2024
6 checks passed
@marctc marctc deleted the revert_k8s_logging branch July 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants