Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build_info metrics to internal metrics #987

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 3, 2024

This PR duplicates the usage of beyla_build_info, ignoring lang label as in this
case is just for Beyla itself. This metric is need for debugging dashboard.

@marctc marctc requested review from grcevski and mariomac as code owners July 3, 2024 13:44
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (84af0d1) to head (9d8108c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   80.59%   80.66%   +0.07%     
==========================================
  Files         134      134              
  Lines       10688    10702      +14     
==========================================
+ Hits         8614     8633      +19     
+ Misses       1565     1562       -3     
+ Partials      509      507       -2     
Flag Coverage Δ
integration-test 55.97% <100.00%> (+0.01%) ⬆️
k8s-integration-test 59.38% <100.00%> (+0.12%) ⬆️
oats-test 36.28% <0.00%> (-0.07%) ⬇️
unittests 50.49% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marctc marctc merged commit 10efe58 into main Jul 3, 2024
8 checks passed
@marctc marctc deleted the build_info_internal branch July 3, 2024 14:53
@marctc marctc restored the build_info_internal branch July 3, 2024 14:53
@marctc marctc deleted the build_info_internal branch July 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants