Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating integration test accessory images #986

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jul 3, 2024

Integration tests still fail, but they will be fixed as soon as we merge this: #984

@mariomac mariomac marked this pull request as ready for review July 3, 2024 08:53
@mariomac mariomac requested review from grcevski and marctc as code owners July 3, 2024 08:53
@mariomac mariomac force-pushed the fix-itests branch 2 times, most recently from e506b6b to a68f222 Compare July 3, 2024 10:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.17%. Comparing base (b34d6de) to head (3981019).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #986       +/-   ##
===========================================
+ Coverage   36.32%   72.17%   +35.84%     
===========================================
  Files         133      133               
  Lines       10642    10642               
===========================================
+ Hits         3866     7681     +3815     
+ Misses       6363     2338     -4025     
- Partials      413      623      +210     
Flag Coverage Δ
integration-test 56.06% <ø> (?)
k8s-integration-test 59.22% <ø> (?)
oats-test 36.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird...good catch

@mariomac mariomac merged commit 0aaaafe into grafana:main Jul 3, 2024
5 of 6 checks passed
@mariomac mariomac deleted the fix-itests branch July 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants