Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service_namespace attr to span metrics #980

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 2, 2024

The resource attribute service_namespace is missing for span metrics generated
from OTEL such as http_server_request_duration_seconds_count. This PR adds
that attribute to these metrics.

Fixes #975

@marctc marctc requested review from grcevski and mariomac as code owners July 2, 2024 10:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.04%. Comparing base (b51cc68) to head (df178b8).

Files Patch % Lines
pkg/internal/request/span_getters.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   66.05%   66.04%   -0.02%     
==========================================
  Files         134      134              
  Lines       10648    10650       +2     
==========================================
  Hits         7034     7034              
- Misses       3124     3126       +2     
  Partials      490      490              
Flag Coverage Δ
oats-test 36.30% <0.00%> (+0.01%) ⬆️
unittests 50.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc marctc merged commit 01f9917 into main Jul 2, 2024
4 of 6 checks passed
@marctc marctc deleted the service_namespace_span branch July 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service_namespace is missing in metrics like http_server_request_duration_seconds_count
3 participants