Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of iteration to 4 to process gRPC frames #977

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jun 27, 2024

No description provided.

@marctc marctc requested review from grcevski and mariomac as code owners June 27, 2024 14:43
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (17203ee) to head (8ef42fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   80.53%   78.51%   -2.02%     
==========================================
  Files         134      134              
  Lines       10601    10601              
==========================================
- Hits         8537     8323     -214     
- Misses       1560     1754     +194     
- Partials      504      524      +20     
Flag Coverage Δ
integration-test ?
k8s-integration-test 59.07% <ø> (+0.04%) ⬆️
oats-test 36.11% <ø> (+0.01%) ⬆️
unittests 50.61% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marctc marctc merged commit fd90b82 into main Jun 27, 2024
6 checks passed
@marctc marctc deleted the reduce_frame_size branch June 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants