Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s_cluster_name to resource attrs #976

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jun 27, 2024

This PR add k8s_cluster_name resource attrs to metrics and traces. This is necessary to generate the link for Kubernetes resource in Application Observability in Grafana.

Closes #935

@marctc marctc requested review from grcevski and mariomac as code owners June 27, 2024 14:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (fd90b82) to head (456fa48).

Files Patch % Lines
pkg/transform/k8s.go 37.50% 15 Missing ⚠️
pkg/transform/clustername.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
+ Coverage   75.58%   80.58%   +4.99%     
==========================================
  Files         134      134              
  Lines       10601    10604       +3     
==========================================
+ Hits         8013     8545     +532     
+ Misses       2093     1557     -536     
- Partials      495      502       +7     
Flag Coverage Δ
integration-test 55.75% <10.00%> (-0.03%) ⬇️
k8s-integration-test 59.00% <46.66%> (?)
oats-test 36.11% <10.00%> (-0.01%) ⬇️
unittests 50.64% <20.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/transform/k8s.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marctc marctc merged commit b51cc68 into main Jul 2, 2024
8 checks passed
@marctc marctc deleted the add_k8s_cluster_name_attr branch July 2, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes links are missing in detail of service
3 participants