Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host.name to process metrics #973

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

mariomac
Copy link
Contributor

One of the many host attributes that we should add: https://opentelemetry.io/docs/specs/semconv/resource/process/

To be fully compliant with OTEL, In a future PR I'll move the host name and other metadata (process info, k8s metadata) to the resource-level attributes or the target_info metric.

@mariomac mariomac marked this pull request as ready for review June 27, 2024 10:34
@mariomac mariomac requested review from grcevski and marctc as code owners June 27, 2024 10:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (512e9d0) to head (7649ec4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
+ Coverage   80.56%   80.65%   +0.08%     
==========================================
  Files         134      134              
  Lines       10591    10601      +10     
==========================================
+ Hits         8533     8550      +17     
+ Misses       1557     1552       -5     
+ Partials      501      499       -2     
Flag Coverage Δ
integration-test 55.80% <90.90%> (+0.07%) ⬆️
k8s-integration-test 59.15% <100.00%> (+0.16%) ⬆️
oats-test 36.07% <54.54%> (-0.01%) ⬇️
unittests 50.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 643c6c3 into grafana:main Jun 27, 2024
6 checks passed
@mariomac mariomac deleted the proc-hostname branch June 27, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants