Fixes to http2 connection detection and bad gRPC paths #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
commented
Jun 26, 2024
| struct { | ||
| __uint(type, BPF_MAP_TYPE_PERCPU_ARRAY); | ||
| __type(key, int); | ||
| __type(value, u8[(IO_VEC_MAX_LEN * 2)]); |
There was a problem hiding this comment.
Had to make this twice as large as the max size we need, otherwise I couldn't convince the verifier the variable sized appends to the buffer are OK.
grcevski
commented
Jun 26, 2024
| @@ -80,7 +80,7 @@ func (p *BPFLogger) processLogEvent(record *ringbuf.Record, _ ebpfcommon.Service | |||
| err := binary.Read(bytes.NewBuffer(record.RawSample), binary.LittleEndian, &event) | |||
|
|
|||
| if err == nil { | |||
| p.log.Info(readString(event.Log[:]), "pid", event.Pid, "comm", readString(event.Comm[:])) | |||
| p.log.Debug(readString(event.Log[:]), "pid", event.Pid, "comm", readString(event.Comm[:])) | |||
There was a problem hiding this comment.
@marctc I realized I was wrong about this, printing on Info really creates a lot of noise when I debug locally. I flipped the log to debug.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
==========================================
+ Coverage 79.48% 80.54% +1.06%
==========================================
Files 132 134 +2
Lines 10378 10591 +213
==========================================
+ Hits 8249 8531 +282
+ Misses 1608 1557 -51
+ Partials 521 503 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
TODO:
Closes #960