Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App metrics/traces: decorate peer service IPs with service names #968

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

mariomac
Copy link
Contributor

Addresses #933

@mariomac mariomac marked this pull request as ready for review June 26, 2024 10:47
@mariomac mariomac requested review from grcevski and marctc as code owners June 26, 2024 10:47
@mariomac mariomac added the bug label Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 83.60656% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (7964686) to head (aaed161).

Files Patch % Lines
pkg/internal/transform/kube/db.go 76.19% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
- Coverage   80.33%   77.76%   -2.57%     
==========================================
  Files         134      134              
  Lines       10487    10544      +57     
==========================================
- Hits         8425     8200     -225     
- Misses       1559     1838     +279     
- Partials      503      506       +3     
Flag Coverage Δ
integration-test 55.92% <14.75%> (-0.09%) ⬇️
k8s-integration-test 59.09% <83.60%> (+0.22%) ⬆️
oats-test ?
unittests 48.83% <16.39%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome!

Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mariomac mariomac merged commit a65ce51 into grafana:main Jun 26, 2024
7 checks passed
@mariomac mariomac deleted the peer-names branch June 26, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants