-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging app and network K8s informers #956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing thanks for doing this so quickly!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 80.04% 80.27% +0.22%
==========================================
Files 133 134 +1
Lines 10522 10477 -45
==========================================
- Hits 8422 8410 -12
+ Misses 1581 1561 -20
+ Partials 519 506 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Inherited from our legacy code, we had two kubernetes informers, one for the Application pipeline and another for the Network pipeline.
This PR unifies both, as a performance improvement (less connection to the Kube API), and as a previous step for some required improvements that will be done in the future, such as letting the users to selectively disable some informers (e.g. ReplicaSets for performance reasons) and decorating service names in Service Graph metrics.