Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one more grpc wrong direction bug #954

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

grcevski
Copy link
Contributor

This PR fixes two more edge case with processing gRPC requests in eBPF:

  1. The gRPC response can be split. The responding service can send one response back and then follow-up with a close frame. In some rare instances we can interpret the second response as a new gRPC start. I added a check that a start cannot be an end at the same time.
  2. In a previous PR I detected that gRPC requests can be split, but when I detected the wrong situation I didn't clean-up the wrong grpc info, so subsequent request may continue from it. This PR adds the delete.

I also fixed the issue reported in #920.

Closes #920

@grcevski grcevski requested review from mariomac and marctc as code owners June 20, 2024 20:37
@grcevski grcevski merged commit d7d75a1 into grafana:main Jun 21, 2024
6 checks passed
@grcevski grcevski deleted the directions branch June 21, 2024 14:09
@grcevski
Copy link
Contributor Author

Thanks @marctc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated service graph metrics have the wrong connection_type label
2 participants