Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTEL traces URL endpoint #952

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix OTEL traces URL endpoint #952

merged 1 commit into from
Jun 20, 2024

Conversation

mariomac
Copy link
Contributor

The OTEL_EXPORTER_OTLP_TRACES_ENDPOINT env variable was broken. Defining it without /v1/traces suffix made the final URL to not having that mandatory path. Defining it with /v1/traces made the final URL to define it twice

@mariomac mariomac added the bug label Jun 20, 2024
@mariomac mariomac requested review from grcevski and marctc as code owners June 20, 2024 14:13
Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 7ba6ea9 into grafana:main Jun 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants