Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in options.md #947

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix link in options.md #947

merged 1 commit into from
Jun 19, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jun 19, 2024

No description provided.

@marctc marctc requested review from grcevski and mariomac as code owners June 19, 2024 10:03
grcevski
grcevski approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac
Copy link
Contributor

Good catch! It surprises me that the multiple and strict docs linters didn't detect that.

@marctc
Copy link
Contributor Author

marctc commented Jun 19, 2024

Good catch! It surprises me that the multiple and strict docs linters didn't detect that.

I thought the same! cc @jdbaldry @grafsean

@marctc marctc merged commit bd8cba9 into main Jun 19, 2024
9 checks passed
@marctc marctc deleted the fix_docs branch June 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

@mariomac mariomac Awaiting requested review from mariomac mariomac is a code owner

Assignees
No one assigned
Labels
backport-1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marctc @mariomac @grcevski