Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable SSL black-box tracing tracking #940

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

grcevski
Copy link
Contributor

The main problem with SSL black-box tracking is that often frameworks use different threads for SSL read and SSL write. Our black box tracking uses the namespaced PID for internal context propagation tracking and it's hard to find what the thread is with SSL. The originating on server read might be different or the same for write.

I'm changing the map which tracks the thread it because the SSL distributed tracing tests were flaky. Sometimes we'd fail to propagate, which I fixed in a previous PR, but it caused internal propagation to fail next.

With this change, the initial thread that sets up the connection info to SSL now remembers the PID context. This will allow us to clean up the server traces correctly, when we clean up the connection info.

@grcevski grcevski requested review from mariomac and marctc as code owners June 17, 2024 14:53
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.48%. Comparing base (c04a1e7) to head (010ae79).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #940       +/-   ##
===========================================
- Coverage   75.74%   63.48%   -12.27%     
===========================================
  Files         131      131               
  Lines       10125    10154       +29     
===========================================
- Hits         7669     6446     -1223     
- Misses       1938     3240     +1302     
+ Partials      518      468       -50     
Flag Coverage Δ
k8s-integration-test ?
oats-test 36.18% <ø> (+0.64%) ⬆️
unittests 47.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit 6162c54 into grafana:main Jun 17, 2024
6 checks passed
@grcevski grcevski deleted the better_ssl_tid_tracking branch June 17, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants