More reliable SSL black-box tracing tracking #940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem with SSL black-box tracking is that often frameworks use different threads for SSL read and SSL write. Our black box tracking uses the namespaced PID for internal context propagation tracking and it's hard to find what the thread is with SSL. The originating on server read might be different or the same for write.
I'm changing the map which tracks the thread it because the SSL distributed tracing tests were flaky. Sometimes we'd fail to propagate, which I fixed in a previous PR, but it caused internal propagation to fail next.
With this change, the initial thread that sets up the connection info to SSL now remembers the PID context. This will allow us to clean up the server traces correctly, when we clean up the connection info.