Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky unit test #939

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix flaky unit test #939

merged 2 commits into from
Jun 17, 2024

Conversation

mariomac
Copy link
Contributor

No description provided.

@mariomac mariomac requested review from grcevski and marctc as code owners June 17, 2024 14:44
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.29%. Comparing base (c04a1e7) to head (690c6ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #939       +/-   ##
===========================================
- Coverage   75.74%   47.29%   -28.45%     
===========================================
  Files         131      131               
  Lines       10125    10125               
===========================================
- Hits         7669     4789     -2880     
- Misses       1938     4998     +3060     
+ Partials      518      338      -180     
Flag Coverage Δ
k8s-integration-test ?
oats-test ?
unittests 47.29% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit df39202 into grafana:main Jun 17, 2024
5 of 6 checks passed
@mariomac mariomac deleted the fix-flaky-test branch June 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants