-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric for instrumented processes #928
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 79.16% 79.31% +0.15%
==========================================
Files 131 131
Lines 9948 10139 +191
==========================================
+ Hits 7875 8042 +167
- Misses 1569 1586 +17
- Partials 504 511 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! What do you think about extending one of our integration tests to ensure this works? Maybe one of those which test multiple processes, then you can enable the internal metrics and confirm we see all services we expect to see?
This PR adds a Gauge to track all services registered by Beyla.
Useful for debugging purpouses. Displays something like this:
Current limtation is for intepreted languanges such Python, Ruby or Java, as we won't visualize
which program are we discovering.