-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process network metrics #925
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 72.28% 79.22% +6.94%
==========================================
Files 130 131 +1
Lines 10026 10104 +78
==========================================
+ Hits 7247 8005 +758
+ Misses 2166 1593 -573
+ Partials 613 506 -107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looks great, one minor comment about testing of the network file parser.
@@ -218,3 +218,17 @@ func Test_usernameFromGetent(t *testing.T) { //nolint:paralleltest | |||
}) | |||
} | |||
} | |||
|
|||
func TestNetworkBytes(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can add a test for bad input there? Like, empty strings, characters instead of numbers etc. I know it's unlikely, but just to be 100% certain we won't panic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
This reverts commit b73549b.
process.network.io
metric, which can be aggregated bynetwork.io.direction=transmit/receive