Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process metrics for disk I/O bytes #924

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

mariomac
Copy link
Contributor

No description provided.

@mariomac mariomac requested review from grcevski and marctc as code owners June 12, 2024 10:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (294b0de) to head (01b6d16).

Files Patch % Lines
pkg/internal/export/otel/metrics_proc.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   72.13%   79.04%   +6.90%     
==========================================
  Files         130      131       +1     
  Lines        9899     9958      +59     
==========================================
+ Hits         7141     7871     +730     
+ Misses       2149     1578     -571     
+ Partials      609      509     -100     
Flag Coverage Δ
integration-test 55.33% <72.72%> (+0.29%) ⬆️
k8s-integration-test 59.79% <75.00%> (+0.22%) ⬆️
oats-test 35.20% <2.27%> (-0.16%) ⬇️
unittests 45.51% <96.59%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing, this is moving so fast!

@mariomac mariomac merged commit 5c20f6f into grafana:main Jun 13, 2024
6 checks passed
@mariomac mariomac deleted the proc-disk branch June 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants