Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up HTTP2 check #923

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Speed up HTTP2 check #923

merged 7 commits into from
Jun 12, 2024

Conversation

grcevski
Copy link
Contributor

This PR adds a quick check for missed HTTP2 connections before we try to use the frame parser from Go. This reduces Beyla's CPU usage on the OTel demo from 25% to less than 3%.

@grcevski grcevski requested review from mariomac and marctc as code owners June 11, 2024 15:25
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.52%. Comparing base (e406a94) to head (eed7f1b).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/internal/ebpf/common/http2grpc_transform.go 89.18% 2 Missing and 2 partials ⚠️
pkg/internal/ebpf/common/tcp_detect_transform.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #923       +/-   ##
===========================================
- Coverage   78.92%   61.52%   -17.41%     
===========================================
  Files         131      131               
  Lines        9862     9945       +83     
===========================================
- Hits         7784     6119     -1665     
- Misses       1572     3393     +1821     
+ Partials      506      433       -73     
Flag Coverage Δ
integration-test ?
k8s-integration-test ?
oats-test 35.31% <46.15%> (-0.24%) ⬇️
unittests 45.41% <79.48%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@grcevski grcevski merged commit 3d4c9da into grafana:main Jun 12, 2024
6 checks passed
@grcevski grcevski deleted the speed_up_http2_check branch June 12, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants