Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process memory metrics #922

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Process memory metrics #922

merged 3 commits into from
Jun 11, 2024

Conversation

mariomac
Copy link
Contributor

Adding the memory metrics from the experimental OTEL specification.

@mariomac mariomac marked this pull request as ready for review June 11, 2024 11:04
@mariomac mariomac requested review from grcevski and marctc as code owners June 11, 2024 11:04
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.08%. Comparing base (8b40a00) to head (8419f11).

Files Patch % Lines
pkg/internal/export/otel/metrics_proc.go 81.25% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   79.10%   79.08%   -0.02%     
==========================================
  Files         131      131              
  Lines        9839     9885      +46     
==========================================
+ Hits         7783     7818      +35     
- Misses       1555     1562       +7     
- Partials      501      505       +4     
Flag Coverage Δ
integration-test 55.19% <91.30%> (+0.01%) ⬆️
k8s-integration-test 59.82% <91.30%> (+0.20%) ⬆️
oats-test 35.49% <5.79%> (-0.19%) ⬇️
unittests 45.40% <91.30%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome!

@mariomac mariomac merged commit 294b0de into grafana:main Jun 11, 2024
6 checks passed
@mariomac mariomac deleted the proc-mem branch June 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants