Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for empty redis commands #916

Merged
merged 1 commit into from
Jun 10, 2024
Merged

check for empty redis commands #916

merged 1 commit into from
Jun 10, 2024

Conversation

esara
Copy link
Contributor

@esara esara commented Jun 10, 2024

address #915

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (e94be3e) to head (6d44f40).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
- Coverage   79.04%   73.87%   -5.18%     
==========================================
  Files         131      131              
  Lines        9832     9832              
==========================================
- Hits         7772     7263     -509     
- Misses       1558     2093     +535     
+ Partials      502      476      -26     
Flag Coverage Δ
integration-test 55.28% <0.00%> (+0.30%) ⬆️
k8s-integration-test ?
oats-test 35.69% <100.00%> (ø)
unittests 45.01% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @esara for another fix!

@grcevski grcevski merged commit 8b40a00 into grafana:main Jun 10, 2024
6 checks passed
@esara esara deleted the redis branch September 29, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants