-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete process metrics for CPU #911
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
+ Coverage 73.66% 79.05% +5.39%
==========================================
Files 131 131
Lines 9755 9832 +77
==========================================
+ Hits 7186 7773 +587
+ Misses 2093 1556 -537
- Partials 476 503 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very cool!
This PR provides the
process.cpu.time
andprocess.cpu.utilisation
metrics according to the definition here: https://opentelemetry.io/docs/specs/semconv/system/process-metrics/It also fixes the way the
process.cpu.utilisation
value was previously provided.New metrics are expirable and their attributes are selectable. This added extra complexity:
process.cpu.state
attribute enabled, the CPU metrics need to be explicitly separated by user/system/wait time. This attribute needs to be explicitly added from the exporters, as it can't be inferred from theprocess.Status
record.process.cpu.state
attribute, the CPU metrics need to be added into a single metric.