Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beyla metrics and traces by default #910

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Jun 7, 2024

When we switched to the OpenTelemetry collector SDK for generating traces we ended up accidentally enabling Beyla internal metrics and traces. This PR reverts that setting. If the internal metrics Prometheus port is enabled, the trace exporter metrics get enabled now.

@grcevski grcevski requested review from mariomac and marctc as code owners June 7, 2024 14:51
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.67%. Comparing base (cd4f89d) to head (dd591c9).

Files Patch % Lines
pkg/internal/export/otel/traces.go 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #910       +/-   ##
===========================================
- Coverage   78.93%   66.67%   -12.27%     
===========================================
  Files         131      130        -1     
  Lines        9742     9746        +4     
===========================================
- Hits         7690     6498     -1192     
- Misses       1553     2671     +1118     
- Partials      499      577       +78     
Flag Coverage Δ
integration-test 55.20% <82.60%> (+0.14%) ⬆️
k8s-integration-test 58.91% <82.60%> (+0.03%) ⬆️
oats-test ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski changed the title Remove beyla metrics and traces Remove beyla metrics and traces by default Jun 7, 2024
@grcevski grcevski merged commit ebaf4af into grafana:main Jun 7, 2024
5 checks passed
@grcevski grcevski deleted the remove_ocol_metrics branch June 7, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants